Skip to content

feat(http)!: add query parameter to route testing utilities #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brendt merged 2 commits into from
Oct 2, 2025
Merged

feat(http)!: add query parameter to route testing utilities #1583

brendt merged 2 commits into from
Oct 2, 2025

Conversation

@innocenzi
Copy link
Member

@innocenzi innocenzi commented Oct 1, 2025

This pull request adds a $query parameter to route testing utils, which allows to do this:

$this->http
    ->get("/oauth/discord/callback", query: [
        'code' => 'some-fake-code',
        'state' => $oauth->getState(),
    ])
    ->assertRedirect();

Instead of having to do this:

$this->http
    ->get("/oauth/discord/callback?code=some-fake-code&state={$oauth->getState()}")
    ->assertRedirect();

@innocenzi innocenzi changed the title feat(http): add query parameter to route testing utilities feat(http)!: add query parameter to route testing utilities Oct 1, 2025
@innocenzi innocenzi marked this pull request as draft October 1, 2025 13:57
@innocenzi innocenzi marked this pull request as ready for review October 1, 2025 14:21
@innocenzi innocenzi requested a review from brendt October 1, 2025 14:34
@brendt
Copy link
Member

brendt commented Oct 2, 2025

Technically this is a breaking change because the $headers array shifted position. I do think most people use named parameters though, so I'm fine merging this.

@brendt brendt merged commit a819979 into main Oct 2, 2025
79 checks passed
@brendt brendt deleted the feat/http-testing-utils branch October 2, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendt brendt Awaiting requested review from brendt

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@innocenzi @brendt